[PATCH] D59216: [LLD][ELF][ARM] Redesign of .ARM.exidx handling to use a SyntheticSection

[Peter Smith via Phabricator via llvm-commits]

peter.smith marked 6 inline comments as done.
peter.smith added a comment.

Thanks for the comments I'll update the diff.



================
Comment at: ELF/SyntheticSections.cpp:3098
+  Size += 8;
+}
+
----------------
grimar wrote:
> Will it be better to do `Size = 8;` from start?
I'm using Size to set the OutSecOff so I need it to start from 0. I'll use a local Offset and derive Size from it to make that a bit clearer.


================
Comment at: ELF/Writer.cpp:940
+    for (InputSection *Ex : In.ARMExidx->ExidxSections)
+      scanRelocations<ELFT>(*Ex);
 }
----------------
pcc wrote:
> This should probably either call `Fn` or we should change `forEachRelSec` to not take a function parameter.
I've changed it to call Fn for the moment, a simple followup NFC refactoring change could remove the parameter if we thought there was not likely to be another likely use of forEachRelSec.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59216/new/

https://reviews.llvm.org/D59216