[PATCH] D58599: [LLD] Add summary support

[Alexandre Ganea via Phabricator via llvm-commits]

aganea updated this revision to Diff 190306.
aganea added a comment.

Simplified as suggested.

Given that lines are printed on-the-spot now, unfortunately they can be interleaved with warnings:

                                      Summary
  --------------------------------------------------------------------------------
                3 Input OBJ files (expanded from all cmd-line inputs)
  lld-link: warning: Cannot use debug info for 'precomp-invalid.obj' [LNK4099]
  >>> failed to load reference 'f:\svn\lld\test\coff\precomp\precomp.obj': The signature does not match; the file(s) might be out of date.
                2 Dependent PCH OBJ files
                4 Output PDB strings
                3 Output global symbol records

Is that what we want?
It wouldn't make things more complicated if we accumulated the messages, and print them on exit?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58599/new/

https://reviews.llvm.org/D58599

Files:
  COFF/Driver.cpp
  COFF/Options.td
  COFF/PDB.cpp
  Common/CMakeLists.txt
  Common/Summary.cpp
  include/lld/Common/Summary.h
  test/COFF/pdb-type-server-simple.test
  test/COFF/precomp-link.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58599.190306.patch
Type: text/x-patch
Size: 7861 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190312/e44075ba/attachment.bin>