[PATCH] D58914: [WebAssembly] Place 'try' and 'catch' correctly wrt EH_LABELs

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 12 11:00:15 PDT 2019


dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

So by "correctly" you mean that the TRY goes before the EH_LABEL rather than between the label and the call, and the CATCH goes after the label rather than at the top of the BB?



================
Comment at: test/CodeGen/WebAssembly/eh-labels.mir:25
+    ; CHECK: TRY
+    ; EH_LABEL
+    ; CALL_VOID @foo
----------------
Should this be `CHECK: EH_LABEL`? (also below)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58914/new/

https://reviews.llvm.org/D58914





More information about the llvm-commits mailing list