[PATCH] D54043: Adding debug info to support Fortran (part 1)

[Eric Schweitz via Phabricator via llvm-commits]

schweitz added inline comments.


================
Comment at: test/DebugInfo/Generic/fortran-subprogram-attr.ll:9
+
+; RUN: llvm-as < %s | llvm-dis | llvm-as | llvm-dis | FileCheck --check-prefix PIPECHK %s
+; PIPECHK: !DISubprogram({{.*}}subroutine1{{.*}}, spFlags: DISPFlagDefinition | DISPFlagPure,
----------------
schweitz wrote:
> aprantl wrote:
> > aprantl wrote:
> > > schweitz wrote:
> > > > aprantl wrote:
> > > > > We usually have the round-trip test in test/Assembler, so it also gets run without object-emission.
> > > > Can someone tell us exactly which file(s) to put what test(s) in?  Thanks.
> > > You can either add a new file or perhaps append it to `llvm/test/Assembler/debug-info.ll`.
> > The second half of the test can stay here.
> Thank you, Adrian.
It looks like test/Assembler/disubprogram.ll is a really good place as well.  It appears to be testing the DISPFlags.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54043/new/

https://reviews.llvm.org/D54043