[PATCH] D59251: [Documentation] Proposal for plan to change variable names

Michael Platings via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 12 08:07:04 PDT 2019


michaelplatings marked 3 inline comments as done.
michaelplatings added inline comments.


================
Comment at: llvm/docs/Proposals/VariableNames.rst:297
+      an improved ``git blame``.
+
+#. Gather feedback and refine the process as appropriate.
----------------
MyDeveloperDay wrote:
> clang-tidy can autoformat any modification with  -format-style=file and it will use a projects .clang-format file to clang-format just the lines that were changed by clang-tidy.
> 
> That removes the need for a separate clang-format run, this should at least help minimize the other changes caused by formatting code outside of the rename, or the need to run git clang-format.
> 
> Potentially you might want to run clang-tidy with JUST the readability-identifier-naming rules turned on so it only fixes those issues and not anything else... (otherwise clang-tidy is going to have a field day!)
Thanks, I've updated the plan accordingly.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59251/new/

https://reviews.llvm.org/D59251





More information about the llvm-commits mailing list