[PATCH] D59149: [LV] move useEmulatedMaskMemRefHack() functionality to TTI.

[Markus Lavin via Phabricator via llvm-commits]

markus added a comment.

Any improvement is an improvement so I am happy with that but it is still mentioned that this solution is a hack and I guess the

> Cost model for emulated masked load/store is completely broken.

comment is still valid. What would it take to address this properly?



================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfoImpl.h:270
+                         (isa<StoreInst>(Inst) && NumPredStores > Threshold);
+    return useHackedCost ? 3000000 : 0;
+  }
----------------
This value seems a bit arbitrary. Could it not be e.g. INT_MAX instead if it is supposed to represent something infinitely expensive?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59149/new/

https://reviews.llvm.org/D59149