[PATCH] D58102: Support X86 Control-flow Enforcement Technology (CET) in LLD

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: test/ELF/i386-feature-1-and.s:23
+# RUN: llvm-readelf -n %t | FileCheck --check-prefix=NGP2 %s
+# RUN: llvm-readelf -S %t | FileCheck --check-prefix=SEC2 %s
+
----------------
MaskRay wrote:
> These `llvm-readelf -S %t` RUN commands can share the same check-prefix. They just check if `.note.gnu.property` is present. (Actually I'm thinking if they can be deleted if the related `llvm-readelf -n` is not empty)
It seems make sense!


================
Comment at: test/ELF/i386-feature-1-and.s:39
+
+# Check .note.gnu.protery
+# SEC1: .note.gnu.property
----------------
MaskRay wrote:
> Typo. The comment may be less useful. A brief comment above the `llvm-mc` `ld.lld` commands explaining what the test is intended for may be more helpful to readers.
Yes, I ll recommands it, in fact, these test is very simple for CET test. 
They just check the flags is ok or not.
The most testing work we need to test in a CET special machine.


================
Comment at: test/ELF/x86-64-feature-1-and.s:39
+
+# Check .note.gnu.protery
+# SEC1: .note.gnu.property
----------------
MaskRay wrote:
> Typo. `protery -> property`
Sorry! ^_^



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58102/new/

https://reviews.llvm.org/D58102