[zorg] r355744 - Revert "Build LLDB with local submodule visibility."

[Adrian Prantl via llvm-commits]

Sorry about the terse commit message. The SDK installed on green-dragon nodes had a not-yet-resolved modularization issue in the system headers.

-- adrian

> On Mar 11, 2019, at 1:55 PM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> Why was this reverted? (handy to have that in the commit message for those following along, etc)
> 
> On Fri, Mar 8, 2019 at 2:11 PM Adrian Prantl via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> Author: adrian
> Date: Fri Mar  8 14:12:38 2019
> New Revision: 355744
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=355744&view=rev <http://llvm.org/viewvc/llvm-project?rev=355744&view=rev>
> Log:
> Revert "Build LLDB with local submodule visibility."
> 
> This reverts commit 355641+355639.
> 
> Modified:
>     zorg/trunk/zorg/jenkins/build.py
>     zorg/trunk/zorg/jenkins/jobs/jobs/lldb-cmake-standalone
>     zorg/trunk/zorg/jenkins/lldb-cmake-matrix-dwarf.sh
>     zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage1.sh
>     zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage2.sh
> 
> Modified: zorg/trunk/zorg/jenkins/build.py
> URL: http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/build.py?rev=355744&r1=355743&r2=355744&view=diff <http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/build.py?rev=355744&r1=355743&r2=355744&view=diff>
> ==============================================================================
> --- zorg/trunk/zorg/jenkins/build.py (original)
> +++ zorg/trunk/zorg/jenkins/build.py Fri Mar  8 14:12:38 2019
> @@ -597,7 +597,6 @@ def lldb_cmake_builder():
>                   '-DCMAKE_MAKE_PROGRAM=' + NINJA,
>                   '-DLLVM_VERSION_PATCH=99',
>                   '-DLLVM_ENABLE_MODULES=On',
> -                 '-DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=On',
>                   '-DCMAKE_EXPORT_COMPILE_COMMANDS=ON',
>                   '-DCMAKE_INSTALL_PREFIX="%s"'%dest_dir,
>                   '-DLLDB_TEST_USER_ARGS='+';'.join(dotest_args),
> 
> Modified: zorg/trunk/zorg/jenkins/jobs/jobs/lldb-cmake-standalone
> URL: http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/jobs/jobs/lldb-cmake-standalone?rev=355744&r1=355743&r2=355744&view=diff <http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/jobs/jobs/lldb-cmake-standalone?rev=355744&r1=355743&r2=355744&view=diff>
> ==============================================================================
> --- zorg/trunk/zorg/jenkins/jobs/jobs/lldb-cmake-standalone (original)
> +++ zorg/trunk/zorg/jenkins/jobs/jobs/lldb-cmake-standalone Fri Mar  8 14:12:38 2019
> @@ -188,7 +188,6 @@ cmake -L $LLDB_SRC \
>      -DCMAKE_BUILD_TYPE=Release \
>      -DLLVM_ENABLE_ASSERTIONS=On \
>      -DLLVM_ENABLE_MODULES=On \
> -    -DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=On \
>      -DLLVM_VERSION_PATCH=99 \
>      -DLLVM_TARGETS_TO_BUILD='X86;ARM;AArch64' \
>      -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
> 
> Modified: zorg/trunk/zorg/jenkins/lldb-cmake-matrix-dwarf.sh
> URL: http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/lldb-cmake-matrix-dwarf.sh?rev=355744&r1=355743&r2=355744&view=diff <http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/lldb-cmake-matrix-dwarf.sh?rev=355744&r1=355743&r2=355744&view=diff>
> ==============================================================================
> --- zorg/trunk/zorg/jenkins/lldb-cmake-matrix-dwarf.sh (original)
> +++ zorg/trunk/zorg/jenkins/lldb-cmake-matrix-dwarf.sh Fri Mar  8 14:12:38 2019
> @@ -89,7 +89,6 @@ cmake $WORKSPACE/llvm \
>      -DCMAKE_BUILD_TYPE=Release \
>      -DLLVM_ENABLE_ASSERTIONS=On \
>      -DLLVM_ENABLE_MODULES=On \
> -    -DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=On \
>      -DLLVM_VERSION_PATCH=99 \
>      -DLLVM_TARGETS_TO_BUILD='X86' \
>      -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
> 
> Modified: zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage1.sh
> URL: http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage1.sh?rev=355744&r1=355743&r2=355744&view=diff <http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage1.sh?rev=355744&r1=355743&r2=355744&view=diff>
> ==============================================================================
> --- zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage1.sh (original)
> +++ zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage1.sh Fri Mar  8 14:12:38 2019
> @@ -74,7 +74,6 @@ cmake $LLVM_SRC \
>      -DCMAKE_BUILD_TYPE=Release \
>      -DLLVM_ENABLE_ASSERTIONS=On \
>      -DLLVM_ENABLE_MODULES=On \
> -    -DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=On \
>      -DLLVM_VERSION_PATCH=99 \
>      -DLLVM_TARGETS_TO_BUILD='X86' \
>      -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
> 
> Modified: zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage2.sh
> URL: http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage2.sh?rev=355744&r1=355743&r2=355744&view=diff <http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage2.sh?rev=355744&r1=355743&r2=355744&view=diff>
> ==============================================================================
> --- zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage2.sh (original)
> +++ zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage2.sh Fri Mar  8 14:12:38 2019
> @@ -80,7 +80,6 @@ function build_clang() {
>      -DCMAKE_BUILD_TYPE=Release \
>      -DLLVM_ENABLE_ASSERTIONS=Off \
>      -DLLVM_ENABLE_MODULES=On \
> -    -DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=On \
>      -DLLVM_TARGETS_TO_BUILD='X86' \
>      -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
>      -DCMAKE_INSTALL_PREFIX="$RESULTS/history/$CLANG_NAME" \
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190311/a61969e0/attachment.html>