[PATCH] D58690: [AArch64] Add code size information on isFPImmLegal

[Evandro Menezes via Phabricator via llvm-commits]

evandro accepted this revision.
evandro added a comment.
This revision is now accepted and ready to land.

LGTM, after the minor issues below are addressed.



================
Comment at: lib/Target/AMDGPU/AMDGPUISelLowering.h:165
+  bool isFPImmLegal(const APFloat &Imm, EVT VT,
+		    bool ForCodeSize) const override;
   bool ShouldShrinkFPConstant(EVT VT) const override;
----------------
Indentation.


================
Comment at: lib/Target/ARM/ARMFastISel.cpp:427
   // a constant, otherwise we have to go through the constant pool.
-  if (TLI.isFPImmLegal(Val, VT)) {
+  if (TLI.isFPImmLegal(Val, VT, false)) {
     int Imm;
----------------
`false` is already the default value.



================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:5887
     // If we can represent the constant as an immediate, don't lower it
-    if (isFPImmLegal(FPVal, VT))
+    if (isFPImmLegal(FPVal, VT, false))
       return Op;
----------------
Ditto.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58690/new/

https://reviews.llvm.org/D58690