[PATCH] D59212: Include an archive file name in an error message for a bad file.

Mon Mar 11 13:07:45 PDT 2019

ruiu added inline comments.

================
Comment at: lld/ELF/InputFiles.cpp:1204
   if (Endian != ELFDATA2LSB && Endian != ELFDATA2MSB)
-    fatal(MB.getBufferIdentifier() + ": invalid data encoding");
+    Fatal("invalid data encoding");
   if (Size != ELFCLASS32 && Size != ELFCLASS64)
----------------
efriedma wrote:
> Not directly a comment on this change... but maybe we should also change the text of these error messages to indicate a general cause in addition to the specific cause, something like "corrupt ELF file (invalid data encoding)".
Makes sense. Updated the error messages.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59212/new/

https://reviews.llvm.org/D59212