[PATCH] D58102: Support X86 Control-flow Enforcement Technology (CET) in LLD

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 11 10:39:33 PDT 2019


ruiu added a comment.

In D58102#1424183 <https://reviews.llvm.org/D58102#1424183>, @xiangzhangllvm wrote:

> Hi friends:
>  I add --auto-cet and --force-cet options, and disable CET in default. Now there will be no influence to the LLD when not using these options.
>  I did these because I want to quickly finish the options discussion, I think it is easy to refine in the future.


We actually need to be careful when adding new command line options. It is after all the only thing our users will see, and a flaw in a design would cause a real pain. In addition to that, a new feature with a new command line option is not something we can refine easily in the future. It is actually opposite: once we add an option, it is extremely difficult to change or remove it. Therefore, it is worth spending a little time to get everything right from beginning.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58102/new/

https://reviews.llvm.org/D58102





More information about the llvm-commits mailing list