[PATCH] D59097: [yaml2obj]Lookup relocation symbols in dynamic symbol when .dynsym referenced

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 11 09:56:55 PDT 2019


jhenderson marked an inline comment as done.
jhenderson added inline comments.


================
Comment at: tools/yaml2obj/yaml2elf.cpp:868
+                              Doc.DynamicSymbols.Weak))
     return 1;
 
----------------
grimar wrote:
> grimar wrote:
> > This place looks a bit overcomplicated (seems requires refactoring), but it is not a problem of this patch.
> I committed NFC in r355832. Open for comments.
> 
Seems reasonable. I'll rebase later, once I've fixed up the other issue. I've got some higher priority work to do first, so this may have to go onto the backburner for a week or two.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59097/new/

https://reviews.llvm.org/D59097





More information about the llvm-commits mailing list