[PATCH] D58047: [LLD][ELF][ARM] Synthesise missing .ARM.exidx sections.

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 11 09:20:00 PDT 2019


peter.smith added a comment.
Herald added a subscriber: MaskRay.

In D58047#1397285 <https://reviews.llvm.org/D58047#1397285>, @ruiu wrote:

> We used to handle .ARM.exidx sections as regular sections with a sentinel section that is synthesized and added to the end. We later added code to merge contiguous .ARM.exidx sections, and now this patch is adding sentinels at various points.  At this point, maybe it is easier to handle .ARM.exidx as a single synthetic section just like MergeInputSection? That synthetic section removes all input section whose name is .ARM.exidx from the input section list and add itself to the input section. That design gives you more flexibility than the current design, as the intermediate data representation doesn't have to be an InputSection.


I've submitted D59216 <https://reviews.llvm.org/D59216> to show what that would look like. I'd like to keep this open until there is an idea of which approach is preferable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58047/new/

https://reviews.llvm.org/D58047





More information about the llvm-commits mailing list