[PATCH] D59085: [LLD][ELF] - Replace one of the tests with a YAML version.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 11 08:50:33 PDT 2019


ruiu added inline comments.


================
Comment at: test/ELF/invalid/data-encoding.test:7
+# RUN: echo ".long foo" > %t.s
+# RUN: llvm-mc %t.s -o %t -filetype=obj -triple x86_64-pc-linux
+
----------------
Please add the ".o" extension to an object file.


================
Comment at: test/ELF/invalid/data-encoding.test:12
+
+# RUN: not ld.lld %t %t.a -o %t2 2>&1 | FileCheck %s
+# CHECK: {{.*}}.o: invalid data encoding
----------------
It is not clear to me why you had to create an object file in addition to an archive file. Can't you just pass an archive file only?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59085/new/

https://reviews.llvm.org/D59085





More information about the llvm-commits mailing list