[PATCH] D58983: DAG: propagate whether an arg is a pointer for CallingConv decisions.

[Tim Northover via Phabricator via llvm-commits]

t.p.northover added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetCallingConv.h:48
     unsigned IsCopyElisionCandidate : 1; ///< Argument copy elision candidate
+    unsigned IsPointer : 1;
 
----------------
arsenm wrote:
> This should probably include the address space. Currently the AMDGPU calling convention lowering hacks through this by looking at the original IR argument index
Sounds plausible. I've added an extra field to parallel the ByValSize thing. It meant bumping up the size but I don't think we're drowning in these structs.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58983/new/

https://reviews.llvm.org/D58983