[PATCH] D59175: [llvm-readobj] Print symbol version when dumping relocations (PR31564)

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:2719
     StringRef StrTable = unwrapOrError(Obj->getStringTableForSymtab(*SymTab));
-    TargetName = maybeDemangle(unwrapOrError(Sym->getName(StrTable)));
+    TargetName = this->dumper()->getFullSymbolName(
+        Sym, StrTable, SymTab->sh_type == SHT_DYNSYM);
----------------
Seems you do not need `this->`


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:2720
+    TargetName = this->dumper()->getFullSymbolName(
+        Sym, StrTable, SymTab->sh_type == SHT_DYNSYM);
   }
----------------
nit: I suggest to add a comment fot the last arg: `SymTab->sh_type == SHT_DYNSYM /* IsDynamic */`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59175/new/

https://reviews.llvm.org/D59175