[PATCH] D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation

Ethan Sommer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 9 13:25:09 PST 2019


E5ten added inline comments.


================
Comment at: compiler-rt/lib/crt/CMakeLists.txt:60
+  )
+  string(FIND ${CHECK_OUTPUT} ${section} SECTION_FOUND)
+
----------------
This causes a cmake error for me: `string sub-command FIND requires 3 or 4 parameters.`, I guess because one of the 2 variables there are empty, quoting the 2 variables fixes the issue for me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D28791/new/

https://reviews.llvm.org/D28791





More information about the llvm-commits mailing list