[PATCH] D59143: [RegisterCoalescer] Limit the number of joins for large live interval with many valnos.

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 8 15:35:00 PST 2019


wmi marked an inline comment as done.
wmi added inline comments.


================
Comment at: llvm/trunk/lib/CodeGen/RegisterCoalescer.cpp:3280-3281
+    return false;
+  if (LargeLIVisitCounter[LI.reg] < LargeIntervalFreqThreshold) {
+    LargeLIVisitCounter[LI.reg]++;
+    return false;
----------------
chandlerc wrote:
> This does the lookup in the hashtable twice, instead bind it to a reference?
Fixed in rL355757 and rL355759. Thanks!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59143/new/

https://reviews.llvm.org/D59143





More information about the llvm-commits mailing list