[PATCH] D59153: [MBP] Make sure the exit BB is the most possible successor before rotating a loop

Guozhi Wei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 8 13:40:19 PST 2019


Carrot created this revision.
Carrot added a reviewer: davidxl.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

In findBestLoopExit it only finds a BB that can exit a loop, but it doesn't consider the exit BB may have other better predecessor. In that case the exit BB is placed after other predecessor, rotation actually makes loop layout worse.


Repository:
  rL LLVM

https://reviews.llvm.org/D59153

Files:
  lib/CodeGen/MachineBlockPlacement.cpp
  test/CodeGen/X86/bb_rotate.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59153.189917.patch
Type: text/x-patch
Size: 3752 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190308/f221424c/attachment.bin>


More information about the llvm-commits mailing list