[PATCH] D59148: [NVPTX][DEBUGINFO]Temp fix for crash of ptxas: disable packed bytes in debug sections.

[Artem Belevich via Phabricator via llvm-commits]

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

> This patch fixes the bug in the ptxas tool with the processing of bytes

'works around' may be a better match as the ptxas still has the bug.



================
Comment at: lib/Target/NVPTX/MCTargetDesc/NVPTXTargetStreamer.cpp:106-127
+  // TODO: uncomment this once the bug in the ptxas with the packed bytes is
+  // resolved. Currently, (it is confirmed by NVidia) it causes a crash in
+  // ptxas.
 
-    const char *Label = Directive;
-    for (auto It = std::next(Data.bytes_begin(), I * MaxLen),
-              End = (I == NumChunks - 1)
-                        ? Data.bytes_end()
-                        : std::next(Data.bytes_begin(), (I + 1) * MaxLen);
-         It != End; ++It) {
-      OS << Label << (unsigned)*It;
-      if (Label == Directive)
-        Label = ",";
-    }
-    Streamer.EmitRawText(OS.str());
-  }
+  // const MCAsmInfo *MAI = Streamer.getContext().getAsmInfo();
+  // const char *Directive = MAI->getData8bitsDirective();
+  // unsigned NumElements = Data.size();
----------------
I'd use `#if 0` to disable the code.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59148/new/

https://reviews.llvm.org/D59148