[PATCH] D58832: [SampleFDO] add suffix elision control for fcn names

Than McIntosh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 8 12:50:29 PST 2019


thanm added a comment.

In D58832#1422205 <https://reviews.llvm.org/D58832#1422205>, @wmi wrote:

> We need function attribute only when we want to use different strategies for different functions. Do we need the function granularity control over the suffix elision policy?


We want to be able to eventually support ThinLTO in which you have a mix of C and Go functions (it is fairly common for Go programs to call out into C code).   Without such a change we'd have to pick one policy or another and hope that it works for code generated by every front end.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58832/new/

https://reviews.llvm.org/D58832





More information about the llvm-commits mailing list