[PATCH] D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: clang/include/clang/Driver/ToolChain.h:104
+    UNW_None,
+    UNW_CompilerRT,
+    UNW_Libgcc
----------------
MaskRay wrote:
> mgorny wrote:
> > phosek wrote:
> > > I think it's confusing to call LLVM's libunwind library compiler-rt since they're two separate and distinct LLVM subprojects. Is there a plan to move LLVM's libunwind into compiler-rt?
> > Also, note that `-lunwind` may actually be 'non-GNU libunwind'. Both libraries normally use the same name.
> Yeah there are lots of projects called "libunwind":
> 
> llvm libunwind
> nongnu libunwind https://www.nongnu.org/libunwind/
> PathScale libunwind https://github.com/pathscale/libunwind (this is used by default On FreeBSD)
> (libgcc_s.so.1 doesn't call itself "libunwind")
There have been suggestions to rename LLVM's libunwind to avoid this confusion in the past, maybe it's time to do it?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59109/new/

https://reviews.llvm.org/D59109