[PATCH] D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst

[Rong Xu via llvm-commits]

On Fri, Mar 8, 2019 at 10:56 AM Sanjay Patel via Phabricator <
reviews at reviews.llvm.org> wrote:

> spatel added a comment.
>
> Minor: it would be better to make the test in IR (opt -codegenprepare), so
> it would live under test/Transforms/CodeGenPrepare/X86/. That's because
> this isn't really an x86 bug. It could affect any target, and the bug is
> really one of an IR transform. Along those lines, I would include
> auto-generated FileCheck output too even if the IR for this example is
> semi-useless, just so we know exactly what it coming out of CGP.
>
This makes a lot of sense. Let me change the test case.


>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D59139/new/
>
> https://reviews.llvm.org/D59139
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190308/981bfd59/attachment.html>