[PATCH] D47770: [MVT][SVE] Add EVT strings and Type mapping

[Robin Kruppe via Phabricator via llvm-commits]

rkruppe added inline comments.


================
Comment at: lib/CodeGen/ValueTypes.cpp:193
   case MVT::v8f64:   return "v8f64";
+  case MVT::nxv1i1:  return "nxv1i1";
+  case MVT::nxv2i1:  return "nxv2i1";
----------------
greened wrote:
> I can't find where these are defined, but given that the IR type is <scalable v4f32> should these names reflect that?  "nx" is nice and short but may be confusing in that the mapping from "scalable" to "nx" isn't necessarily obvious.
As MC layer support for SVE started landing quite a while ago, the backend types too landed back then with names matching the then-current proposal for the IR types (`<n x 4 x ...>`). I agree it would be nice to have the backend type names match, but that's a bunch of churn, so it shouldn't be coupled to this patch and should wait until the IR type system changes are committed in case their name changes again.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47770/new/

https://reviews.llvm.org/D47770