[PATCH] D58956: [WebAssembly] Remove tabs in tests (NFC)

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 7 11:33:01 PST 2019


tlively added a comment.

In D58956#1421908 <https://reviews.llvm.org/D58956#1421908>, @sbc100 wrote:

> But what about then the tabs form part of the program under test's output?   Whats that argument against allowing them?   Surely it makes it easier if one can (or at least has the option to) simply copy and paste the expectations?


Yeah, that's fair. And I've never seen an issue where a tab appeared in a source file. I have had issues with white space at the ends of lines in tests, though. My editor likes to automatically remove them whenever I save those files, which causes extra noise in my diffs that I have to manually undo. So a policy against end-of-line white space would actually be helpful for me.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58956/new/

https://reviews.llvm.org/D58956





More information about the llvm-commits mailing list