[PATCH] D59062: [GlobalISel][AArch64] Always fall back on aarch64.neon.addp.*

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/LegalizerInfo.cpp:448-453
 bool LegalizerInfo::isLegal(const MachineInstr &MI,
                             const MachineRegisterInfo &MRI) const {
-  return getAction(MI, MRI).Action == Legal;
+  auto Action = getAction(MI, MRI).Action;
+  // If the action is custom, it may not necessarily modify the instruction,
+  // so we have to assume it's legal.
+  return Action == Legal || Action == Custom;
----------------
This is really isLegalOrCustom. It may be useful to have both


================
Comment at: lib/Target/AArch64/AArch64LegalizerInfo.h:38
+
+  bool legalizeIntrinsic(MachineInstr &MI, MachineRegisterInfo &MRI,
+                         MachineIRBuilder &MIRBuilder) const;
----------------
Should this be added separately by D31359?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59062/new/

https://reviews.llvm.org/D59062