[PATCH] D59014: [TTI] Enable analysis of clib functions in getIntrinsicCosts. NFCI.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 7 08:28:03 PST 2019


RKSimon added inline comments.


================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:817
+  /// source/destination type and alignment and the number of bytes copied.
+  int getMemcpyCost(const Instruction *I) const;
+
----------------
Why do we need to provide individual cost functions like this? Isn't that what getCallCost/getIntrinsicCost are there for?


================
Comment at: include/llvm/Analysis/TargetTransformInfoImpl.h:26
 #include "llvm/IR/Type.h"
+#include "llvm/IR/IntrinsicInst.h"
 
----------------
include ordering - clang-format should fix this


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59014/new/

https://reviews.llvm.org/D59014





More information about the llvm-commits mailing list