[PATCH] D59082: [yaml2obj] - Allow producing ELFDATANONE ELFs

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/tools/yaml2obj/elf-header-data.yaml:6
+
+# Both llvm-readobj and obj2yaml currently recognize that the object is invalid.
+# RUN: not llvm-readobj -file-headers %t.o 2>&1 | FileCheck %s
----------------
jhenderson wrote:
> What about llvm-objdump? I'm guessing they all rely on the same Object library, so all get the error from the same place?
> 
> Perhaps a better test is to show using something like `od` that the byte at EI_DATA is 0?
> What about llvm-objdump? I'm guessing they all rely on the same Object library, so all get the error from the same place?
Yes.

> Perhaps a better test is to show using something like od that the byte at EI_DATA is 0?
Done, thanks for the hint about od!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59082/new/

https://reviews.llvm.org/D59082