[PATCH] D59023: [RISCV] Support -target-abi at the MC layer and for codegen

[Ana Pazos via Phabricator via llvm-commits]

apazos added inline comments.


================
Comment at: lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.h:41
+    else
+      report_fatal_error(ABIOrError.takeError());
+  }
----------------
I find strange that instantiating a backend can cause an error. 


================
Comment at: lib/Target/RISCV/Utils/RISCVBaseInfo.cpp:55
+
+  return TargetABI;
+}
----------------
Instead of returning error, should we just use the default abi setting you apply in the beginning of this function (ILP32 or ILP64)  and print a warning? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59023/new/

https://reviews.llvm.org/D59023