[PATCH] D58801: [Support] Implement is_local_impl with AIX mntctl

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 6 11:33:58 PST 2019


Hahnfeld added a comment.

In D58801#1420179 <https://reviews.llvm.org/D58801#1420179>, @hubert.reinterpretcast wrote:

> Ping. I am looking for some input on whether we want to pursue additional testing.


Yes, testing this is hard because we can have all possible combinations of the source and the build directory being remote / local.

I think creating a directory and checking that a contained file returns the same value as the directory should work. However I'm not sure how much value this adds. If it's reasonably easy to implement I think it makes sense, but personally I wouldn't see it as requirement for this patch


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58801/new/

https://reviews.llvm.org/D58801





More information about the llvm-commits mailing list