[PATCH] D59012: [WebAssembly] LTO: Don't include bitcode-only symbols in the symtab

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 6 10:27:12 PST 2019


pcc added inline comments.


================
Comment at: lld/wasm/Writer.cpp:953
   for (Symbol *Sym : Symtab->getSymbols())
-    if (!Sym->isLazy())
+    if (!Sym->isLazy() && Sym->IsUsedInRegularObj)
       AddSymbol(Sym);
----------------
Can this just be `if (Sym->IsUsedInRegularObj)`? AFAICT this flag is not set on lazy symbols (nor should it be).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59012/new/

https://reviews.llvm.org/D59012





More information about the llvm-commits mailing list