[PATCH] D59025: Add --add-ghashes to llvm-objcopy to append a .debug$H to coff objects

Wed Mar 6 09:40:22 PST 2019

santagada added a comment.

In D59025#1419985 <https://reviews.llvm.org/D59025#1419985>, @aganea wrote:

> > The only problem I have with this change is that apparently link.exe doesn't like the obj files after the section is added...
>
> Could you add more detail? Could you possibly try to pinpoint the issue with a very small use-case please?
>  LLVM-generated OBJs shall be 100% compatible with MSVC-generated ones. If they are not, we should fix that.

Well, link.exe seems to get "confused" it doesn't print any error messages and produce a very big file that is not really an executable. Without any messages or symbols for it its a bit difficult to see what is happening. As I mostly did the same as the gnu-link option does, I guess those obj files should have the same problem.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59025/new/

https://reviews.llvm.org/D59025