[PATCH] D59007: [WebAssembly] Use named operands to identify loads and stores

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 5 17:11:50 PST 2019


tlively created this revision.
tlively added reviewers: aheejin, dschuff.
Herald added subscribers: llvm-commits, jfb, sunfish, hiraditya, jgravelle-google, sbc100.
Herald added a project: LLVM.

Uses the named operands tablegen feature to look up the indices of
offset, address, and p2align operands for all loading
instructions. This replaces brittle, incorrect logic for identifying
loads and store when eliminating frame indices which crashed on
bulk-memory ops. It also cleans up the SetP2Alignment pass, causing it
to work on SIMD loads when it did not before.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D59007

Files:
  llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h
  llvm/lib/Target/WebAssembly/WebAssemblyInstrAtomics.td
  llvm/lib/Target/WebAssembly/WebAssemblyInstrInfo.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyInstrInfo.h
  llvm/lib/Target/WebAssembly/WebAssemblyInstrMemory.td
  llvm/lib/Target/WebAssembly/WebAssemblyRegisterInfo.cpp
  llvm/lib/Target/WebAssembly/WebAssemblySetP2AlignOperands.cpp
  llvm/test/CodeGen/WebAssembly/bulk-memory.ll
  llvm/test/CodeGen/WebAssembly/simd-load-store-alignment.ll
  llvm/test/CodeGen/WebAssembly/simd-offset.ll
  llvm/test/CodeGen/WebAssembly/simd.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59007.189429.patch
Type: text/x-patch
Size: 83710 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190306/61f00f18/attachment-0001.bin>


More information about the llvm-commits mailing list