[PATCH] D59003: [GN] Locate prebuilt binaries correctly.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/utils/gn/gn.py:41
-    if subprocess.call([gn, '--version'], stdout=open(os.devnull, 'w'),
-                                          stderr=subprocess.STDOUT) != 0:
         # Not on path. See if get.py downloaded a prebuilt binary and run that
----------------
Maybe you could pass `shell=True` here instead? On my machine at least, that causes the shell to fail if the command is not found instead of an exception being thrown.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59003/new/

https://reviews.llvm.org/D59003