[PATCH] D58698: [DWARFFormValue] Don't consider DW_FORM_data4/8 to be section offsets.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

In D58698#1419173 <https://reviews.llvm.org/D58698#1419173>, @aprantl wrote:

> Is there a way to make the DWARF unit non-optional in this function?


Sorry, I landed this before seeing your comment. No, unfortunately it's not. The way the DWARFForm class works is that you can either initialize it yourself with a value (in which case there is no context or unit) or you can read it from data (in which case both are set). The only way to guarantee that we have a DWARF version in both scenarios would be to make it mandatory to pass a version number, which would become possible as the result of my recent refactoring.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58698/new/

https://reviews.llvm.org/D58698