[PATCH] D58998: Add declarations of explicit specializations and make primary template deleted

Thomas Köppe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 5 15:41:41 PST 2019


tkoeppe added a comment.

In D58998#1419205 <https://reviews.llvm.org/D58998#1419205>, @jyknight wrote:

> Is there any reason this needs to be a template -- can't these just be changed to function overloads, instead of template specializations?


They could, but...

a) I wanted to make a minimal change and respect the original design,
b) Richard Smith told me offline that he had also considered it but doesn't much care either way, and
c) I was suspecting some attempt to speed up compilation by keeping the overload set minimal, which I didn't want to second-guess lightly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58998/new/

https://reviews.llvm.org/D58998





More information about the llvm-commits mailing list