[PATCH] D58909: [llvm-objcopy] - Report "no zlib available" error properly when --compress-debug-sections is used.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 5 01:02:42 PST 2019


grimar added a comment.

In D58909#1417023 <https://reviews.llvm.org/D58909#1417023>, @jhenderson wrote:

> Can you write a test that is UNSUPPORTED if zlib IS available?


I think we have such a test already. It is:
https://github.com/llvm-mirror/llvm/blob/master/test/tools/llvm-objcopy/ELF/compress-debug-sections-invalid-format.test
(It does not do `# REQUIRES: zlib` because code report the `Invalid or unsupported --compress-debug-sections format` error before `zlib::isAvailable()` check.
What looks fine to me.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58909/new/

https://reviews.llvm.org/D58909





More information about the llvm-commits mailing list