[PATCH] D58881: [Transform] Improve fold of sadd.with.overflow

Mon Mar 4 23:20:52 PST 2019

lebedev.ri added a comment.

In D58881#1417653 <https://reviews.llvm.org/D58881#1417653>, @dlrobertson wrote:

> > I've committed your tests with the current output in rL355328 <https://reviews.llvm.org/rL355328>. Can you please rebase this revision over the committed tests, so that only the changes made by the new transform remain?
>
> Is this the preferred way to add tests? E.g. for the future changes I make for `uadd.with.overflow`, should I add the tests in a diff and then follow the diff up with another that also contains code changes?

Yes, absolutely.

1. That makes the diff readable. The changes will be visible, not just the test addition.
2. That helps with test coverage. You want those tests regardless of whether the change itself will land or be reverted.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58881/new/

https://reviews.llvm.org/D58881