[PATCH] D58862: [cmake] Create exports for umbrella library targets

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 4 16:37:41 PST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL355354: [cmake] Create exports for umbrella library targets (authored by smeenai, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D58862?vs=189019&id=189229#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58862/new/

https://reviews.llvm.org/D58862

Files:
  cfe/trunk/cmake/modules/AddClang.cmake
  llvm/trunk/cmake/modules/AddLLVM.cmake


Index: cfe/trunk/cmake/modules/AddClang.cmake
===================================================================
--- cfe/trunk/cmake/modules/AddClang.cmake
+++ cfe/trunk/cmake/modules/AddClang.cmake
@@ -91,6 +91,7 @@
     if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY OR ${name} STREQUAL "libclang")
 
       if(${name} IN_LIST LLVM_DISTRIBUTION_COMPONENTS OR
+          "clang-libraries" IN_LIST LLVM_DISTRIBUTION_COMPONENTS OR
           NOT LLVM_DISTRIBUTION_COMPONENTS)
         set(export_to_clangtargets EXPORT ClangTargets)
         set_property(GLOBAL PROPERTY CLANG_HAS_EXPORTS True)
Index: llvm/trunk/cmake/modules/AddLLVM.cmake
===================================================================
--- llvm/trunk/cmake/modules/AddLLVM.cmake
+++ llvm/trunk/cmake/modules/AddLLVM.cmake
@@ -633,6 +633,7 @@
   # config file.
   if (NOT ARG_BUILDTREE_ONLY AND NOT ARG_MODULE)
     set_property( GLOBAL APPEND PROPERTY LLVM_LIBS ${name} )
+    set(in_llvm_libs YES)
   endif()
 
   if (ARG_MODULE AND NOT TARGET ${name})
@@ -663,6 +664,7 @@
       endif()
 
       if(${name} IN_LIST LLVM_DISTRIBUTION_COMPONENTS OR
+          (in_llvm_libs AND "llvm-libraries" IN_LIST LLVM_DISTRIBUTION_COMPONENTS) OR
           NOT LLVM_DISTRIBUTION_COMPONENTS)
         set(export_to_llvmexports EXPORT LLVMExports)
         set_property(GLOBAL PROPERTY LLVM_HAS_EXPORTS True)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58862.189229.patch
Type: text/x-patch
Size: 1359 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190305/d6afa297/attachment.bin>


More information about the llvm-commits mailing list