[PATCH] D58929: [LoopRotate] fix crash encountered with callbr

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/test/Transforms/LoopRotate/callbr.ll:4
+
+ at d = external dso_local local_unnamed_addr global i64, align 8
+ at f = external dso_local local_unnamed_addr global i32, align 4
----------------
Drop the dso_local and local_unnamed_addr attributes throughout


================
Comment at: llvm/test/Transforms/LoopRotate/callbr.ll:61
+
+!llvm.ident = !{!0}
+
----------------
Drop this.


================
Comment at: llvm/test/Transforms/LoopRotate/callbr.ll:63
+
+!0 = !{!"clang version 9.0.0 (https://github.com/llvm/llvm-project.git d3b300358d649d55afbc7c9941429790cc0381c4)"}
+!1 = !{!2, !2, i64 0}
----------------
Remove !tbaa and !srcloc in the IR above and then you can remove !0 through !8


================
Comment at: llvm/test/Transforms/LoopRotate/callbr.ll:73
+
+; CHECK: @o
+; CHECK: .lr.ph2
----------------
Use utils/update_test_checks.py to generate the checks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58929/new/

https://reviews.llvm.org/D58929