[PATCH] D56913: decoupling Freestanding atomic<T> from libatomic.a

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 4 11:18:15 PST 2019


davide added a comment.

In D56913#1417184 <https://reviews.llvm.org/D56913#1417184>, @__simt__ wrote:

> In D56913#1417172 <https://reviews.llvm.org/D56913#1417172>, @davide wrote:
>
> > This commit broke the atomic lldb data formatter.
> >
> > http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/21037/
> >
> > @shafik @jingham
>
>
> It looks like LLDB is naming internal names here. Unfortunately, it now needs to learn the new names. On the plus side, there is now a single stable internal name for all compilation paths for this header, whereas it used to differ. So the final result ought to be seen as an improvement.


Nobody disagrees but the formatter has to be fixed, hence the two people cc:ed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56913/new/

https://reviews.llvm.org/D56913





More information about the llvm-commits mailing list