[PATCH] D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 4 08:09:13 PST 2019


jsji accepted this revision.
jsji added a comment.
This revision is now accepted and ready to land.

LGTM, except some minor update. Thanks for fixing!



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:2466
+    // operand in same MI.
+    for (int i = 0, e = It->getNumOperands(); i != e; ++i) {
+      MachineOperand &MO = It->getOperand(i);
----------------
This is almost identical to line 2442 , and it is for a special case handling, can we make it a lamda and just add the call here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58428/new/

https://reviews.llvm.org/D58428





More information about the llvm-commits mailing list