[PATCH] D58837: [ELF] Fix GCC8 warnings about "fall through", NFCI

[Jonas Hahnfeld via Phabricator via llvm-commits]

Hahnfeld marked 3 inline comments as done.
Hahnfeld added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/elf-dynamic-section-machine-specific.test:1
+# Test that hexagon machine-specific tags can be dumped.
+# RUN: yaml2obj --docnum=1 %s -o %t.hex
----------------
MaskRay wrote:
> Hahnfeld wrote:
> > MaskRay wrote:
> > > This file duplicates `test/tools/llvm-readobj/elf-dynamic-tags-machine-specific.test` 
> > > 
> > > Does `FileCheck %S/../llvm-readobj/xxxxx.test` work?
> > Yes, but from what I've seen in reviews so far it's generally not a good idea to reuse tests for two separate tools. And it wouldn't work anyway because the format is different.
> > 
> > What we could do though is moving the ELF description to some `INPUTS/` and use it in both tests. That would leave the checks separate, but de-duplicate the yaml content. Let me know if you think that's worth it.
> Sorry my previous comment was a bit off. The check lines are separate from the rest of the input file. So it should be possible to use `llvm-objdump <some operations> %S/../llvm-readobj/xxx.test | FileCheck %s`
I've put it into `%S/../llvm-readobj/Inputs/` which should make the intent clear that the file is used by multiple tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58837/new/

https://reviews.llvm.org/D58837