[PATCH] D58837: [ELF] Fix GCC8 warnings about "fall through", NFCI

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 2 07:54:46 PST 2019


Hahnfeld updated this revision to Diff 189049.
Hahnfeld marked 2 inline comments as done.
Hahnfeld edited the summary of this revision.
Hahnfeld added a comment.
Herald added subscribers: rupprecht, atanasyan, arichardson, sdardis.

Replace `llvm_unreachable`s in `Object/ELF.cpp` by `break` statements and add test to exercise this code path.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58837/new/

https://reviews.llvm.org/D58837

Files:
  llvm/lib/Object/ELF.cpp
  llvm/lib/Target/X86/MCTargetDesc/X86ELFObjectWriter.cpp
  llvm/test/tools/llvm-objdump/elf-dynamic-section-machine-specific.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58837.189049.patch
Type: text/x-patch
Size: 11241 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190302/722fa480/attachment-0001.bin>


More information about the llvm-commits mailing list