[PATCH] D58801: [Support] Implement is_local_impl with AIX mntctl

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 1 12:23:51 PST 2019


hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added inline comments.


================
Comment at: lib/Support/Unix/Path.inc:446
 
 std::error_code is_local(const Twine &Path, bool &Result) {
   struct STATVFS Vfs;
----------------
There's no testing for this. The previous attempt at having testing for this interface was removed in http://llvm.org/viewvc/llvm-project?view=revision&revision=297260. It seems that a reasonable expectation is that a newly created file and its parent directory would produce the same answer when queried. I am not sure if there is a desire to pursue adding such a test.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58801/new/

https://reviews.llvm.org/D58801





More information about the llvm-commits mailing list