[PATCH] D58767: [compiler-rt] [CMake] Don't use llvm_replace_compiler_option

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 1 11:44:47 PST 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: CMakeLists.txt:382
+      CMAKE_CXX_FLAGS_RELWITHDEBINFO)
+      string(REGEX REPLACE "(^| )/Z[i7I]($| )" " /Z7 "
+             "${var_to_update}" "${${var_to_update}}")
----------------
I think the indentation here should be two spaces less


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58767/new/

https://reviews.llvm.org/D58767





More information about the llvm-commits mailing list