[PATCH] D58117: Workaround std::thread begin not copy-constructible

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 1 11:09:21 PST 2019


dblaikie added a comment.

In D58117#1414613 <https://reviews.llvm.org/D58117#1414613>, @kcc wrote:

> 1. I am not sure what problem does it solve. Everything seems to work.
> 2. We can now safely remove fuzzer_allocator and rename Vector to just plain std::vector. (we don't need this monstrosity any more since we are using private STL now)


It was a workaround for a bug in an unreleased version of libstdc++ - nothing to fix on our end.

I think this change should be abandoned.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58117/new/

https://reviews.llvm.org/D58117





More information about the llvm-commits mailing list