[PATCH] D58795: ELF: Write .eh_frame_hdr explicitly after writing .eh_frame.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 1 10:41:50 PST 2019


pcc added a comment.

In D58795#1414819 <https://reviews.llvm.org/D58795#1414819>, @peter.smith wrote:

> It looks like this change broke the clang-armv7-linux-build-cache which uses clang 5.0.1 running on a 32-bit ARM container http://lab.llvm.org:8011/builders/clang-armv7-linux-build-cache/builds/11063 . I've committed a temporary fix that r355195 that changes FileSize to use size_t rather than uint64_t. Mentioning it here just in case you want to fix it in different way.


Hmm, it should probably be a uint64_t so that we can detect size overflows better on 32-bit platforms. Sent D58840 <https://reviews.llvm.org/D58840> with the fix.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58795/new/

https://reviews.llvm.org/D58795





More information about the llvm-commits mailing list