[PATCH] D58836: [InstCombine] Extend saturating idempotent atomicrmw transform to FP
JF Bastien via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 1 10:36:07 PST 2019
jfb accepted this revision.
jfb added a subscriber: scanon.
jfb added a comment.
This revision is now accepted and ready to land.
Two nits, LGTM, with @scanon for visibility.
================
Comment at: lib/Transforms/InstCombine/InstCombineAtomicRMW.cpp:60
/// Return true if the given instruction always produces a value in memory
/// equivelent to its value operand.
bool isSaturating(AtomicRMWInst& RMWI) {
----------------
Typo "equivalent"
================
Comment at: lib/Transforms/InstCombine/InstCombineAtomicRMW.cpp:77
default:
// TODO: fadd, fsub w/Nan
return false;
----------------
Remove TODO
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58836/new/
https://reviews.llvm.org/D58836
More information about the llvm-commits
mailing list