[PATCH] D58753: [NFC][Sanitizer] Make GetStackTrace a private method of BufferedStackTrace

[Julian Lettner via Phabricator via llvm-commits]

yln marked 2 inline comments as done.
yln added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_stack.cc:31
 
-void __sanitizer::GetStackTrace(BufferedStackTrace *stack, uptr max_depth,
-                                uptr pc, uptr bp, void *context, bool fast) {
+void __sanitizer::BufferedStackTrace::UnwindRuntime(
+    uptr pc, uptr bp, void *context, bool request_fast, u32 max_depth) {
----------------
vitalybuka wrote:
> I don't understand meaning of Runtime here.
> Maybe UnwindRuntime -> UnwindImpl
> 
> Final decision is up to you
> if you prefere Runtime, maybe UnwindByRuntime?
Okay, let's go with UnwindImpl.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58753/new/

https://reviews.llvm.org/D58753